[sql lab] only show single run query button #1858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -208,7 +149,13 @@ class SqlEditor extends React.PureComponent { | |||
| <div className="sql-toolbar clearfix"> | |||
| <div className="pull-left"> | |||
| <Form inline> | |||
| {runButtons} | |||
| <RunQueryActionButton | |||
| queryEditor={this.props.queryEditor} | |||
There was a problem hiding this comment.
Curious to hear your thoughts on passing larger objects or more specific props. For instance here we could define a isTextSelected prop instead of passing queryEditor. Similarly we could pass allowAsync instead of database.
Isn't it better to pass the more targeted props? It probably means less re-rendering.
I guess it depends on how the component may or may not evolve (say to use other attributes of that object), and whether we'd want to use the component outside of the context of the application / object definition.
There was a problem hiding this comment.
this is a good point. i agree passing in just the props the component needs is ideal. i'll make this change.
ascott
force-pushed
the
alanna-default-to-async
branch
from
b1d312a to
0081e6f
Compare
ascott
force-pushed
the
alanna-default-to-async
branch
2 times, most recently
from
b52e6a5 to
cef62f2
Compare
ascott
force-pushed
the
alanna-default-to-async
branch
from
cef62f2 to
12eee9f
Compare
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run QueryandRun Async Queryfixes this issue: #1819
before
after
plz review @mistercrunch @vera-liu @bkyryliuk