Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Items are not translated (hardcoded) #25990

Open
xavier-GitHub76 opened this issue Nov 15, 2023 · 3 comments
Open

Items are not translated (hardcoded) #25990

xavier-GitHub76 opened this issue Nov 15, 2023 · 3 comments

Comments

@xavier-GitHub76
Copy link
Contributor

Hello,
I had created an issue (#21493) but it has multiples cause of no translation.
I specialise this issue on elements hardcoded

Items are not translated because they are not present in https://github.com/apache/superset/blob/3.0/superset/translations/en/LC_MESSAGES/messages.json
and french translations

image

Items are :

  • "It's not a good policy to remove a user, just make it inactive"
  • Select value (rôle)
  • The user role on the application, this will associate with a list of permissions
  • Your database was successfully connected! Here are some optional settings for your database
  • SCREENSHOT WIDTH
  • Input custom width in pixels
  • "Click here to edit Markdown"

Example :
image

Bests regards

@xavier-GitHub76
Copy link
Contributor Author

I use Superset in version 3.0.0

@dkrat7
Copy link
Contributor

dkrat7 commented Nov 16, 2023

Some of these elements are part of FAB (flask appbuilder) module and have to be translated there.

@rusackas
Copy link
Member

rusackas commented Apr 8, 2024

CC @dpgaspar for an opinion here... if this is a FAB issue, I don't think there's much we can do on the Superset side, and we can close it, and perhaps file an issue on that repo.

For any strings in Superset, we don't typically support these as bugs but you're welcome to open a PR that adds either translated strings to existing translated strings, or turn any static strings into translated strings in the codebase (e.g. adding t(string) on the frontend).

Tempted to close this as stale anyway, but I'll leave it open hoping that we can get further thoughts on the matter and/or a PR to address it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants