-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the Gamma role user experience #359
Comments
Right. We need to iron out the gamma user experience and fix some other things around security. It's pretty rough right now. |
I have disabled some of these features in #298 based on access permissions. They cannot be clicked if the user does not have respective access permissions. |
#298 looks great for slices, any chance we could do something very very similar for dashboards too? |
I added features for dashboard as well in the same PR. Saving dashboard etc is disabled now. |
On current master the "Save the current positioning and CSS" does not give any feedback when the save fails. I think we just need to disable the button if the user don't have enough permissions to save it. Same goes for "Add a new slice to the dashboard" |
With gamma users saving the dashboard model would fail if they are not owner of the dashboard. So if that's not the case just disable the "Add a new slice to the dashboard" and "Save the current positioning and CSS". Refs apache#359
As we don't want to leak other users to unpriviliged users Refs apache#359
With gamma users saving the dashboard model would fail if they are not owner of the dashboard. So if that's not the case just disable the "Add a new slice to the dashboard" and "Save the current positioning and CSS". Refs #359
While logged in as a user without access rights to save new dashboard positioning and css, if they click the "Save the current positioning and CSS" button, they get a modal message "Success, This dashboard was saved successfully." although it hasn't been successful (and if you reload the dashboard the changes have not been saved - which is the correct behaviour for a user without sufficient rights).
Either the modal message should say "Unable to save dashboard due to insufficient access permissions", or the save button should be hidden for users without sufficient rights. I think one tidy solution might be to hide/disable the entire multi-button (refresh, filter, css, edit, save) for users without edit rights.
The text was updated successfully, but these errors were encountered: