Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[theme] a little bit less blue #1024

Merged
merged 2 commits into from
Aug 30, 2016
Merged

[theme] a little bit less blue #1024

merged 2 commits into from
Aug 30, 2016

Conversation

mistercrunch
Copy link
Member

before/after
screen shot 2016-08-26 at 6 00 41 pm
screen shot 2016-08-26 at 6 00 16 pm

@ascott
Copy link

ascott commented Aug 29, 2016

what does /caravel/theme/ look like with these changes?

ascott
ascott reviewed Aug 29, 2016
View reviewed changes
caravel/assets/stylesheets/less/cosmo/bootswatch.less
background-color: transparent;
}
.panel-title {
color: black;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prefer hex values #000000;

Copy link

@ascott ascott Aug 29, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but this should probably also be a variable, probably @text-color

@mistercrunch
Copy link
Member Author

Addressed comments, merging

@mistercrunch mistercrunch merged commit 9f8eef4 into apache:master Aug 30, 2016
@mistercrunch mistercrunch deleted the less_blue branch August 30, 2016 22:02
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.11.0 labels Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mistercrunch @ascott