[SQL Lab] Adding DB options for SQL LAb #1054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistercrunch
force-pushed
the
db_options_sqllab
branch
from
a24afa5 to
e7abef5
Compare
each db can be exposed or not in SQL Lab CTAS is an option target_schema placeholder (not hooked yet, but would force the CTAS to target a specific schema)
mistercrunch
force-pushed
the
db_options_sqllab
branch
from
e7abef5 to
029957f
Compare
| actions: React.PropTypes.object, | ||
| database: React.PropTypes.object, |
There was a problem hiding this comment.
could you please add a comment specifying the schema of the object ?
There was a problem hiding this comment.
let's define where we store schemas (maybe as functions that return objects)
mistercrunch
force-pushed
the
db_options_sqllab
branch
from
b7bd41f to
2c3a193
Compare
|
Addressed all comments, mergin'! |
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 17, 2021
* Add slovenia.geojson * Update countries.ts
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 24, 2021
* Add slovenia.geojson * Update countries.ts
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 25, 2021
* Add slovenia.geojson * Update countries.ts
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 26, 2021
* Add slovenia.geojson * Update countries.ts
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
each db can be exposed or not in SQL Lab
CTAS is an option
target_schema placeholder (not hooked yet, but would force the CTAS to
target a specific schema)