Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add get_viz method to the slice. #1062

Closed
wants to merge 3 commits into from
Closed

Add get_viz method to the slice. #1062

wants to merge 3 commits into from

Conversation

bkyryliuk
Copy link
Member

@bkyryliuk bkyryliuk commented Sep 3, 2016 •
edited
Loading

Implementation of the #1021

Tested:

  • manually created / renamed/ modified the slices and tested .csv, .json and explore endpoints
  • unit tests cover basic slice exploration
  • checked that error messages are popping up on the screen:
    screen shot 2016-09-02 at 1 04 56 pm

Reviewers:

@bkyryliuk bkyryliuk mentioned this pull request Sep 4, 2016
Merged
@bkyryliuk
Copy link
Member Author

closing as it is a part of the #1063

@bkyryliuk bkyryliuk closed this Sep 6, 2016
@amitmiran137 amitmiran137 mentioned this pull request Apr 26, 2021
Merged
8 tasks
@snyk-bot snyk-bot mentioned this pull request Jun 2, 2021
Open
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 17, 2021
@villebro @zhaoyongjie
chore(plugin-chart-echarts): bump echarts to 5.1.0 (apache#1062)
fe78784 
* chore(plugin-chart-echarts): bump echarts to 5.1.0

* disable ts error
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 24, 2021
@villebro @zhaoyongjie
chore(plugin-chart-echarts): bump echarts to 5.1.0 (apache#1062)
5f3e14a 
* chore(plugin-chart-echarts): bump echarts to 5.1.0

* disable ts error
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 25, 2021
@villebro @zhaoyongjie
chore(plugin-chart-echarts): bump echarts to 5.1.0 (apache#1062)
0a82d23 
* chore(plugin-chart-echarts): bump echarts to 5.1.0

* disable ts error
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 26, 2021
@villebro @zhaoyongjie
chore(plugin-chart-echarts): bump echarts to 5.1.0 (apache#1062)
d97d706 
* chore(plugin-chart-echarts): bump echarts to 5.1.0

* disable ts error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bkyryliuk