More improvements to SQL Lab #1104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ); | ||
| } | ||
| if (this.props.database && this.props.database.allow_run_async) { | ||
| runButtons.push( |
There was a problem hiding this comment.
would be nice to DRY this up. could make a <RunButton /> component to encapsulate the logic and returns the correct button based on the input:
<RunButton
async={this.props.database && this.props.database.allow_run_async}
sync={this.props.database && this.props.database.allow_run_sync}
isRunning={this.props.latestQuery && this.props.latestQuery.state === 'running'}
/>
There was a problem hiding this comment.
could probably simply further by only passing the async prop. if async is false, use sync.
<RunButton
async={this.props.database && this.props.database.allow_run_async}
isRunning={this.props.latestQuery && this.props.latestQuery.state === 'running'}
/>
|
Sorry about the quality of the PR I was rushing things through to get a working release |
mistercrunch
force-pushed
the
sqllab
branch
3 times, most recently
from
66982f4 to
162b8b0
Compare
Long column name were looking weird and icons were wrapping oddly
mistercrunch
force-pushed
the
sqllab
branch
3 times, most recently
from
fa5d7ea to
6e6bf43
Compare
mistercrunch
force-pushed
the
sqllab
branch
from
6e6bf43 to
a64ee9b
Compare
|
Rogue merging this PR. I'll sort things out around async mode in upcoming PRs. |
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 17, 2021
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 24, 2021
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 25, 2021
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 26, 2021
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.