Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add docs for GLOBAL_ASYNC_QUERIES (SIP-39) #12573

Merged
merged 1 commit into from
Jan 19, 2021

Conversation

robdiciuccio
Copy link
Member

@robdiciuccio robdiciuccio commented Jan 17, 2021

SUMMARY

Adds documentation for GLOBAL_ASYNC_QUERIES feature, including all configuration settings. See #11499 for related code.

ADDITIONAL INFORMATION

  • Has associated issue: [SIP-39] Global Async Query Support #9190
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@robdiciuccio robdiciuccio requested a review from villebro January 17, 2021 01:25
@robdiciuccio robdiciuccio added rush! Requires immediate attention doc:developer Developer documentation v1.0 labels Jan 17, 2021
@codecov-io
Copy link

codecov-io commented Jan 17, 2021

Codecov Report

Merging #12573 (f33f2bf) into master (deebd6f) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #12573   +/-   ##
=======================================
  Coverage   66.75%   66.75%           
=======================================
  Files        1015     1015           
  Lines       49633    49633           
  Branches     4839     4839           
=======================================
+ Hits        33133    33134    +1     
+ Misses      16377    16376    -1     
  Partials      123      123           
Flag Coverage Δ
cypress 51.02% <ø> (+0.04%) ⬆️
javascript 60.74% <ø> (ø)
python 63.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...set-frontend/src/dashboard/util/getDropPosition.js 93.65% <0.00%> (+1.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update deebd6f...f33f2bf. Read the comment docs.

@junlincc junlincc added v1.0.1 and removed v1.0 labels Jan 17, 2021
@junlincc
Copy link
Member

junlincc commented Jan 17, 2021

we cut rc4 and kicked off the vote on Friday night. Async query docs update can go in the patch release, right? as it's not directly related to any urgent issues. given that we have Monday off, and announcing 1.0 on Thursday, we won't have enough time to the get this in. have to change label to v.1.0.1. 🙏

@junlincc junlincc removed preset-io rush! Requires immediate attention labels Jan 17, 2021
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. If there are any Celery/Redis specific configs that have been found to work well it could also be nice to add those to the documentation (see e.g. #11499 (comment) )

@robdiciuccio robdiciuccio merged commit 10c2b09 into apache:master Jan 19, 2021
@robdiciuccio robdiciuccio deleted the rd/async-query-docs branch January 19, 2021 21:57
@mistercrunch mistercrunch added 🍒 1.0.1 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels doc:developer Developer documentation size/M v1.0.1 🍒 1.0.1 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants