Change slice ids in the position json during dashboard import. #1380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
bkyryliuk
commented
Oct 20, 2016
| new_slc_id_str = '{}'.format(new_slc_id) | ||
| old_slc_id_str = '{}'.format(slc.id) | ||
| if ('expanded_slices' in i_params_dict and | ||
| old_slc_id_str in i_params_dict['expanded_slices']): |
There was a problem hiding this comment.
|
LEBTM (looks even better to me) :) |
neevany
pushed a commit
to Kieraya/caravel
that referenced
this pull request
Oct 24, 2016
…e#1380) * Change slice ids in the position json during dashboard import. * Update slice ids in the dashboard json metadata.
6 tasks
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Position config is tied to the slice ids.
In order to preserve the dashboard config and appearances we have to update the slice ids in the position_json attr in the dashboard.
Reviewers:
CC: