Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved fetching table metadata from SqlEditorLeftBar to actions #1494

Merged
merged 2 commits into from
Nov 1, 2016
Merged

Moved fetching table metadata from SqlEditorLeftBar to actions #1494

merged 2 commits into from
Nov 1, 2016

Conversation

vera-liu
Copy link
Contributor

Before:

  • ajax call for fetching table and metadata were in changeTable() of SqlEditorLeft

After:

  • moved ajax call to action creators and dispatch actions from there

This doesn't change any UI.

needs-review @mistercrunch

@mistercrunch
Copy link
Member

LGTM!

@vera-liu vera-liu merged commit 5238053 into apache:master Nov 1, 2016
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.13.0 labels Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vera-liu @mistercrunch