Moved queriesArray from render() to local state #1505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
is only reloaded only during switching tabs or queries object is updated.
mistercrunch
requested changes
Nov 1, 2016
| @@ -94,3 +94,18 @@ export function areArraysShallowEqual(arr1, arr2) { | |||
| } | |||
| return true; | |||
| } | |||
|
|
|||
| export function areObjectsEqual(obj1, obj2) { | |||
There was a problem hiding this comment.
I think there's a missing case here where obj2 has properties that are not in obj1.
There was a problem hiding this comment.
Added length comparison in latest commit
| queriesArray.push(this.props.queries[id]); | ||
| } | ||
| } | ||
| this.setState({ queriesArray }); |
There was a problem hiding this comment.
I wonder if it would be kosher to mutate nextProps in componentWillReceiveProps the docs don't seem to say whether it is...
There was a problem hiding this comment.
I remember that props are immutable, why would we want to mutate nextProps?
There was a problem hiding this comment.
nevermind, that was bad idea!
mistercrunch
approved these changes
Nov 1, 2016
|
LGTM! |
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
needs-review @mistercrunch