-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dnd): add isExtra prop to Option #15080
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## master #15080 +/- ##
==========================================
+ Coverage 77.78% 77.81% +0.02%
==========================================
Files 966 967 +1
Lines 49629 49672 +43
Branches 6314 6328 +14
==========================================
+ Hits 38606 38652 +46
+ Misses 10822 10819 -3
Partials 201 201
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
closes #15106 |
SUMMARY
The Drag and drop option was missing the
isExtra
prop, causing the warning triangle to be missing when exploring a chart with extra filters.BEFORE
AFTER
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION