Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[explore-v2] control panel fixes #1529

Merged
merged 6 commits into from
Nov 3, 2016
Merged

[explore-v2] control panel fixes #1529

merged 6 commits into from
Nov 3, 2016

Conversation

ascott
Copy link

@ascott ascott commented Nov 2, 2016

  • make fieldset conditions more clear
  • use slugify util for turning labels into ids
  • a few other fixes based on max's comments

@mistercrunch @vera-liu

@mistercrunch
Copy link
Member

LGTM

@ascott ascott merged commit 4156ad5 into apache:master Nov 3, 2016
@ascott ascott deleted the ascott-control-panel-fixes branch November 3, 2016 04:51
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.13.0 labels Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ascott @mistercrunch