Pass values from global store to fields in exploreV2 #1561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vera-liu
force-pushed
the
vliu_pass_store_to_fields
branch
from
b4e2591 to
6dcad81
Compare
ascott
reviewed
Nov 8, 2016
| @@ -14,6 +14,7 @@ const propTypes = { | |||
| places: PropTypes.number, | |||
| validators: PropTypes.any, | |||
| onChange: React.PropTypes.func, | |||
| value: PropTypes.any, | |||
There was a problem hiding this comment.
we could use PropTypes.oneOf([PropTypes.string, PropTypes.bool]) here to be more specific.
ascott
reviewed
Nov 8, 2016
| @@ -1630,6 +1630,7 @@ const defaultFormData = {}; | |||
| defaultFormData.slice_name = null; | |||
| defaultFormData.slice_id = null; | |||
| Object.keys(fields).forEach((k) => { defaultFormData[k] = fields[k].default; }); | |||
| exports.defaultFormData = defaultFormData; | |||
There was a problem hiding this comment.
it would be nice to use the
export function thing() {} or export const thing = {} syntax here, rather than exports.thing = thing;
maybe defaultFormData should be a function like this:
export function defaultFormData() {
const data = {
slice_name: null,
slice_id: null,
};
Object.keys(fields).forEach((k) => { data[k] = fields[k].default; });
return data;
}
|
a few comments, but otherwise LGTM |
vera-liu
force-pushed
the
vliu_pass_store_to_fields
branch
from
6dcad81 to
2f76b4f
Compare
vera-liu
force-pushed
the
vliu_pass_store_to_fields
branch
from
2f76b4f to
9b3c460
Compare
|
🎉 |
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done:
e.g. when show_legend is set to true in url, checkbox will be toggled when loading
needs-review @ascott