Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[table viz] allow sorting on any column #1601

Merged
merged 2 commits into from
Nov 17, 2016
Merged

[table viz] allow sorting on any column #1601

merged 2 commits into from
Nov 17, 2016

Conversation

mistercrunch
Copy link
Member

@mistercrunch mistercrunch commented Nov 15, 2016 •
edited
Loading

Ordering should be possible on any column not just numerical ones.

@ascott , I couldn't find easily where to make the equivalent change in explorev2, any pointers?

@ascott
Copy link

ascott commented Nov 15, 2016

@mistercrunch https://github.com/airbnb/superset/blob/master/superset/views.py#L2125

@mistercrunch mistercrunch merged commit ab5da5b into apache:master Nov 17, 2016
@mistercrunch mistercrunch deleted the table_sort branch November 17, 2016 15:15
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.14.0 labels Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.14.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mistercrunch @ascott