Make nvd3 refresh smoother on dashboard #1618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the-dcruz
force-pushed
the
smooth-nvd3-refresh
branch
from
5dd2f55 to
2e7dbf1
Compare
|
would be great to check the other nvd3 viz's work with this change:
otherwise, LGTM! |
|
|
the-dcruz
force-pushed
the
smooth-nvd3-refresh
branch
from
2e7dbf1 to
2875f69
Compare
the-dcruz
commented
Nov 17, 2016
| @@ -73,6 +73,7 @@ function query(forceUpdate, pushState) { | |||
| // update the url after prepForm() fix the field ids | |||
| history.pushState({}, document.title, slice.querystring()); | |||
| } | |||
| slice.container.html(''); | |||
There was a problem hiding this comment.
I added this line because I noticed some strange behavior in box-plot and pie charts when I changed major parts of the query such as the the dimension I was grouping by.
Example of strange behavior:
- Pie chart not resizing properly when hovered.
On a dashboard, the same query would always be firing from each slice so it shouldn't be an issue.
|
@ascott I've checked all the nvd3 visualizations and they're rendering and refreshing as expected |
|
thanks @the-dcruz! |
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Currently, refreshing nvd3 visualizations is not very pleasant to look at especially when set to refresh every 10 seconds:
The problem is that upon render, the entire slice container is emptied which means the whole chart must render from scratch instead of just adjusting to new data.
Solution
If we leave the chart intact upon refesh, nvd3 will automatically update the entire chart smoothly.
Notice the bars and x-axis shift in this example.
@mistercrunch