[explore-v2] add fave star and edit button to chart header #1623
Conversation
|
This PR needs to be linted to pass the build |
| } | ||
|
|
||
| onClick(e) { | ||
| e.preventDefault(); |
There was a problem hiding this comment.
I am curious, what is default behavior?
There was a problem hiding this comment.
since we are using an <a href="#"> here, we want to stop the default behaviour of the browser following the href path, in this case just adding # to the url.
https://developer.mozilla.org/en/docs/Web/API/Event/preventDefault
| } | ||
|
|
||
| export default function TooltipWrapper({ label, tooltip, children, placement}) { | ||
| console.log('children', children) |
There was a problem hiding this comment.
yep. looks like my linter stopped working in sublime for some reason, so i missed this. thanks for the 👀
| if (data.count > 0) { | ||
| dispatch(toggleFaveStar(true)); | ||
| } | ||
| }); |
There was a problem hiding this comment.
codeclimate says: Missing semicolon.
| @@ -49,6 +53,33 @@ export function fetchFieldOptions(datasourceId, datasourceType) { | |||
| }; | |||
| } | |||
|
|
|||
| export const FETCH_FAVE_STAR = 'FETCH_FAVE_STAR' | |||
There was a problem hiding this comment.
codeclimate says: Missing semicolon.
| const url = `${FAVESTAR_BASE_URL}/${sliceId}/count`; | ||
| $.get(url, (data) => { | ||
| if (data.count > 0) { | ||
| dispatch(toggleFaveStar(true)); |
There was a problem hiding this comment.
codeclimate says: "toggleFaveStar" was used before it was defined
| } | ||
| } | ||
|
|
||
| export const SAVE_FAVE_STAR = 'SAVE_FAVE_STAR' |
There was a problem hiding this comment.
codeclimate says: Missing semicolon.
| const urlSuffix = isStarred ? 'unselect' : 'select'; | ||
| const url = `${FAVESTAR_BASE_URL}/${sliceId}/${urlSuffix}/`; | ||
| $.get(url); | ||
| dispatch(toggleFaveStar(!isStarred)); |
There was a problem hiding this comment.
codeclimate says: "toggleFaveStar" was used before it was defined
| const url = `${FAVESTAR_BASE_URL}/${sliceId}/${urlSuffix}/`; | ||
| $.get(url); | ||
| dispatch(toggleFaveStar(!isStarred)); | ||
| } |
There was a problem hiding this comment.
codeclimate says: Missing semicolon.
| @@ -1,6 +1,10 @@ | |||
| /* eslint camelcase: 0 */ | |||
| const $ = window.$ = require('jquery'); | |||
|
|
|||
| // todo: fix bug in favstar endpoint that requires | |||
| // that /undefined/ is part of this url. | |||
| const FAVESTAR_BASE_URL = '/superset/favstar/undefined'; | |||
There was a problem hiding this comment.
s/undefined/Slice:
@expose("/favstar/<class_name>/<obj_id>/<action>/")
| export const FETCH_FAVE_STAR = 'FETCH_FAVE_STAR' | ||
| export function fetchFaveStar(sliceId) { | ||
| return function (dispatch) { | ||
| const url = `${FAVESTAR_BASE_URL}/${sliceId}/count`; |
There was a problem hiding this comment.
there is no such action is count, I believe you can keep it with no action and the endpoint will return you the count
ascott
force-pushed
the
alanna-expv2-fave-edit-btn
branch
from
6ec36df to
258ef2b
Compare
mistercrunch
added
🏷️ bot
plz review @vera-liu @mistercrunch @bkyryliuk