New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temperary fix of a slice bug in explore V2 #1648

Merged

vera-liu merged 1 commit into apache:master from vera-liu:vliu_nvd3_v2_bug

Nov 22, 2016

Contributor

vera-liu commented Nov 19, 2016

Issue:

Changes in https://github.com/airbnb/superset/pull/1618 were not working in exploreV2, causing the Chart Container not cleaning up graphs at re-rendering,
e.g. after switching viz_type, previous graph is still shown

Fix:

Added back the html cleaning in nvd3
Cleaned up some left over typos in mock slice

needs-review @ascott


          Temperary fix of a slice bug

405cc5f

vera-liu changed the title ~~Temperary fix of a slice bug~~ Temperary fix of a slice bug in explore V2

ascott commented Nov 22, 2016

LGTM! 🎉

vera-liu merged commit bdae570 into apache:master

mistercrunch added 🏷️ bot 🚢 0.14.0 labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot 🚢 0.14.0