Make QueryTable scrollable in Query Search page #1656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ascott
reviewed
Nov 21, 2016
| queries={this.state.queriesArray} | ||
| actions={this.props.actions} | ||
| /> | ||
| <div className="scrollbar-container"> |
There was a problem hiding this comment.
how are you setting the height on the scrolling container? wonder if this is an opportunity to create a <ScrollingContainer /> component since we are using it in a few places..
There was a problem hiding this comment.
Now I use 95% in height to allow space for navbar header, which is pretty hacky. There's another solution here https://github.com/airbnb/superset/pull/1611
vera-liu
force-pushed
the
vliu_query_search_scrollable
branch
from
13f6815 to
e6d4b6c
Compare
|
LGTM |
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: After change in https://github.com/airbnb/superset/pull/1551, query search page is not scrollable because overflow is set to hidden for body
Solution: we want QueryTable to scroll but not the search selects
After:
Note:
After merging https://github.com/airbnb/superset/pull/1611, we need similar changes in QuerySearch to take height of select-boxes into account
needs-review @ascott @mistercrunch @bkyryliuk