Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QuerySearch] Add loading status to QuerySearch page #1657

Merged
merged 1 commit into from
Nov 21, 2016

Conversation

vera-liu
Copy link
Contributor

Done:

  • Add loading state to QuerySearch
  • Move ajax call to ComponentDidMount
  • Show loading image during ajax call

giphy 10

needs-review @ascott @bkyryliuk @mistercrunch

 * Add loading state to QuerySearch
 * Move ajax call to ComponentDidMount
 * Show loading image during ajax call
@ascott
Copy link

ascott commented Nov 21, 2016

LGTM when tests are passing. 🚢

@vera-liu vera-liu merged commit bd6a439 into apache:master Nov 21, 2016
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.14.0 labels Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.14.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants