fix: Remove export CSV in old filter box #16592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duynguyenhoang
changed the title
Codecov Report
@@ Coverage Diff @@
## master #16592 +/- ##
=======================================
Coverage 76.72% 76.72%
=======================================
Files 1003 1003
Lines 53836 53838 +2
Branches 7287 7289 +2
=======================================
+ Hits 41303 41305 +2
Misses 12293 12293
Partials 240 240
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
villebro
reviewed
Sep 6, 2021
| <Menu.Item key={MENU_KEYS.EXPORT_CSV}>{t('Export CSV')}</Menu.Item> | ||
| )} | ||
| {isFeatureEnabled(FeatureFlag.ALLOW_FULL_CSV_EXPORT) && | ||
| {this.props.slice.viz_type !== 'filter_box' && |
There was a problem hiding this comment.
Future improvement idea: maybe we should have a property enableExportCSV on ChartMetadata which defaults to true
villebro
pushed a commit
that referenced
this pull request
Sep 6, 2021
(cherry picked from commit 3fe2e6e)
opus-42
pushed a commit
to opus-42/incubator-superset
that referenced
this pull request
Nov 14, 2021
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 28, 2021
mistercrunch
added
🍒 1.3.1
🍒 1.3.2
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
There is no reason to export Filter box to CSV, we should remove Export CSV link as well as Export Full CSV link in filter box.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before
After
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION