Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sqllab] bugfix SouthPane doesn't update as expected #1699

Merged
merged 2 commits into from
Nov 29, 2016
Merged

[sqllab] bugfix SouthPane doesn't update as expected #1699

merged 2 commits into from
Nov 29, 2016

Conversation

mistercrunch
Copy link
Member

@vera-liu managing mutations in the controller while using PureComponent across the board, using nextProps where it should be used

@vera-liu
Copy link
Contributor

LGTM!

@mistercrunch mistercrunch merged commit b7019ad into apache:master Nov 29, 2016
@mistercrunch mistercrunch deleted the fix_component_update branch November 29, 2016 00:24
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.14.0 labels Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.14.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mistercrunch @vera-liu