Adding links pointing to the new user profile page #1704
Conversation
mistercrunch
force-pushed
the
link_profile
branch
from
972885c to
13f0eb7
Compare
| if not user: | ||
| return '' | ||
| url = '/superset/profile/{}/'.format(user.username) | ||
| return '<a href="{}">{}</a>'.format(url, escape(user) or '') |
There was a problem hiding this comment.
why do we return html here? looks like we should just be returning the url.
There was a problem hiding this comment.
that's for the list_columns view of the CRUD generated "Dashboards" and "Slices" page. We're tricking the list view into displaying links.
There was a problem hiding this comment.
in flask we can put links instead of the text, DatasourceAccessRequest is implemented in similar fashion.
@mistercrunch :
s/escape(user)/escape(user.username)
|
lgtm |
| @@ -1767,7 +1767,7 @@ def recent_activity(self, user_id): | |||
| ) | |||
| .filter( | |||
| sqla.and_( | |||
| M.Log.action != 'queries', | |||
| ~M.Log.action.in_(('queries', 'shortner', 'sql_json')), | |||
There was a problem hiding this comment.
oddly overloaded operator for NOT
| } | ||
| if o.Dashboard.created_by: | ||
| user = o.Dashboard.created_by | ||
| d['creator'] = str(user) |
There was a problem hiding this comment.
s/ str(user)/'{}'.format(user.username) to be consistent and a bit more implicit
There was a problem hiding this comment.
I think the repr of the object is good here, in some organization the username may not always be very explicit and can't be changed. For example early employees of companies get to pick their usernames/handles. We had a fair amount of those at FB.
| } | ||
| if o.Slice.created_by: | ||
| user = o.Slice.created_by | ||
| d['creator'] = str(user) |
|
LGTM once comments are resolved |
|
Gonna let that one slip in as is. We can always alter it later. |
mistercrunch
added
🏷️ bot
No description provided.