-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Reorder install instructions in CONTRIBUTING.md #17387
Conversation
Pinging @dpgaspar for a review because it's a little bit FAB-related, and I miss his face. |
Codecov Report
@@ Coverage Diff @@
## master #17387 +/- ##
=======================================
Coverage 77.02% 77.02%
=======================================
Files 1038 1038
Lines 56013 56013
Branches 7735 7735
=======================================
Hits 43142 43142
Misses 12613 12613
Partials 258 258
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
I'll approve this :) I spent a bunch of time recently with the first "one minute" of setting up superset and this change makes sense. Thanks Will! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the improvement!
Great to "see" you here @willbarrett! this makes perfect sense. |
SUMMARY
The install documentation recommended creating an admin user before setting up the database. This PR reorders the install instructions so that the database structure is created before attempting to create an admin user.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION