Replace stack trace with error message in explorev2 #1817

vera-liu · 2016-12-13T01:28:45Z

Before:

when there are errors in viz.get_json, bootstrap_data is not loaded, stack trace is shown (this happens when user refreshes the page with wrong form_data)

After:

actual error message is shown in ChartContainer when user refresh the page with wrong form_data, and viz_type is set back to 'table'

vera-liu · 2016-12-13T01:29:45Z

superset/views.py

+                viz_json = json.loads(viz_obj.get_json())
+                bootstrap_data["viz"] = viz_json
+            except Exception as e:
+                bootstrap_data["error"] = str(e)


we could also send back the whole stack trace here, suggestions?

mistercrunch · 2016-12-14T17:03:48Z

This one line PR here #1827 fixes the problem you are describing (stack trace). I also fixes the fact that we shouldn't send the data synchronously on the explore view load.

Replace stack trace with error message in explorev2

e2b8388

vera-liu commented Dec 13, 2016

View reviewed changes

vera-liu changed the title ~~cReplace stack trace with error message in explorev2~~ Replace stack trace with error message in explorev2 Dec 13, 2016

vera-liu closed this Dec 14, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replace stack trace with error message in explorev2 #1817

Replace stack trace with error message in explorev2 #1817

vera-liu commented Dec 13, 2016

vera-liu Dec 13, 2016

mistercrunch commented Dec 14, 2016

Replace stack trace with error message in explorev2 #1817

Replace stack trace with error message in explorev2 #1817

Conversation

vera-liu commented Dec 13, 2016

vera-liu Dec 13, 2016

Choose a reason for hiding this comment

mistercrunch commented Dec 14, 2016