[explorev2] making Datasource an Viz controls not clearable #1845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ascott
reviewed
Dec 15, 2016
| @@ -50,10 +52,11 @@ export default class SelectField extends React.Component { | |||
| return opt.label; | |||
| } | |||
| render() { | |||
| const options = this.props.choices.map((c) => ({ value: c[0], label: c[1] })); | |||
| const choices = this.props.choices || []; | |||
There was a problem hiding this comment.
we could add choices: [] in defaultProps, to get rid of this line.
ascott
reviewed
Dec 15, 2016
| @@ -7,12 +7,13 @@ import Select, { Creatable } from 'react-select'; | |||
| const propTypes = { | |||
| name: PropTypes.string.isRequired, | |||
| choices: PropTypes.array, | |||
| value: PropTypes.oneOfType([PropTypes.string, PropTypes.number, PropTypes.array]).isRequired, | |||
| value: PropTypes.oneOfType([PropTypes.string, PropTypes.number, PropTypes.array]), | |||
There was a problem hiding this comment.
curious why this is no longer required...
There was a problem hiding this comment.
I'm not sure why it was there in the first place, seems like conceptually value can be null, especially if the field is clearable, which they all were. I'd have to run some checks on master but I'm thinking this was throwing warnings and I removed the isRequired to stop the warnings.
|
lgtm |
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other SelectField and new ones can now be set as non-clearable for places where null isn't right.