[sqllab] bugfix visualizing a query with a semi-colon #1869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistercrunch
force-pushed
the
bugfix_semi_query
branch
3 times, most recently
from
bdb0be1 to
0e5e13d
Compare
mistercrunch
force-pushed
the
bugfix_semi_query
branch
from
0e5e13d to
86066aa
Compare
ascott
reviewed
Jan 4, 2017
| def stripped(self): | ||
| sql = self.sql | ||
| if sql: | ||
| while sql[-1] in (' ', ';', '\n', '\t'): |
There was a problem hiding this comment.
are there any other line endings we should consider adding?
There was a problem hiding this comment.
those are the only blank characters I could think of, there'll be this place to add new ones if it comes up
SalehHindi
pushed a commit
to SalehHindi/superset
that referenced
this pull request
Jun 9, 2017
* [sqllab] bugfix visualizing a query with a semi-colon * Fixing tests
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1835