read anon user role from config, remove reference to public role #1878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…' to testing configuration
|
@willgroves thanks, next time please force push on the very same branch instead of opening a new PR. |
xrmx
reviewed
Dec 25, 2016
| @@ -205,7 +205,8 @@ def check_ownership(obj, raise_if_false=True): | |||
|
|
|||
| def get_user_roles(): | |||
| if g.user.is_anonymous(): | |||
| return [appbuilder.sm.find_role('Public')] | |||
| public_role = config.get('AUTH_ROLE_PUBLIC', None) | |||
| @@ -205,7 +205,8 @@ def check_ownership(obj, raise_if_false=True): | |||
|
|
|||
| def get_user_roles(): | |||
| if g.user.is_anonymous(): | |||
| return [appbuilder.sm.find_role('Public')] | |||
| public_role = config.get('AUTH_ROLE_PUBLIC', None) | |||
| return [appbuilder.sm.find_role(public_role)] if public_role is not None else [] | |||
There was a problem hiding this comment.
if public_role else [] should be a bit better, i don't think we want to consider things like an empty string as valid role.
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces #1483 and rebases those changes on the current master.
The get_user_roles should get the role specified for the anon user in the config.py at the key AUTH_ROLE_PUBLIC. Without this fix, the list of tables the anon user can see is limited to the tables visible to the "Public" role.