Add a Async Select that fetches options from given endpoint #1909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vera-liu
force-pushed
the
vliu_async_select
branch
from
672bb88 to
a08c487
Compare
ascott
reviewed
Jan 5, 2017
| wrapper.find('[name="select-user"]') | ||
| .simulate('change', { value: 1 }); | ||
| expect(wrapper.state().userId).to.equal(1); | ||
| expect(wrapper.find(Select)).to.have.length(3); |
There was a problem hiding this comment.
should this assert 3 or 4 selects? it was 4 before this change.
There was a problem hiding this comment.
after we switched the user select to AsyncSelect it became 3
There was a problem hiding this comment.
ok cool. we should update the it statement on L21 to read should have three selects in that case.
ascott
reviewed
Jan 5, 2017
| render() { | ||
| return ( | ||
| <div> | ||
| <Select |
There was a problem hiding this comment.
what do we show when the select is loading data?
There was a problem hiding this comment.
isLoading is true when loading the data, Select will render a spinner
|
LGTM after updating the |
|
|
||
| const defaultProps = { | ||
| placeholder: 'Select ...', | ||
| value: null, |
There was a problem hiding this comment.
I think null defaults are implicit.
|
Neat! This reusable component is super useful to have! |
vera-liu
force-pushed
the
vliu_async_select
branch
from
6e42191 to
71232b6
Compare
vera-liu
force-pushed
the
vliu_async_select
branch
from
38487c7 to
a2f7caf
Compare
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done:
UI stays the same as in old Select:
needs-review @ascott @mistercrunch @bkyryliuk