Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change fields for dual_line to match with new SelectField structure #1932

Merged
merged 3 commits into from
Jan 11, 2017
Merged

Change fields for dual_line to match with new SelectField structure #1932

merged 3 commits into from
Jan 11, 2017

Conversation

vera-liu
Copy link
Contributor

@vera-liu vera-liu commented Jan 9, 2017

Issue:

Fixed:

  • Changed fields for metric_2 and y_axis_2_format
  • Checking whether two metrics are the same in query_obj

needs-review @ascott @mistercrunch @bkyryliuk

@mistercrunch
Copy link
Member

LGTM

@vera-liu vera-liu merged commit 94d2016 into apache:master Jan 11, 2017
SalehHindi pushed a commit to SalehHindi/superset that referenced this pull request Jun 9, 2017
@vera-liu
Change fields for dual_line to match with new SelectField structure (a…
c8496b0 
…pache#1932)
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.15.2 labels Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.15.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vera-liu @mistercrunch