Use POST in sqllab_viz instead of url params to avoid error with long queries #1933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vera-liu
force-pushed
the
vliu_visualize_long_query
branch
from
c507e7a to
23e177f
Compare
| success: (url) => { | ||
| window.open(url); | ||
| }, | ||
| error: (error) => { |
There was a problem hiding this comment.
is this error handling better than no error handling? i think there's an action to add an alert that will be visible by the user
There was a problem hiding this comment.
since this is redirecting to a new explore page, adding alert in sqllab won't be intuitive, I'll delete this error handling.
| @@ -2278,7 +2278,7 @@ def sqllab_viz(self): | |||
| } | |||
| params = "&".join([k + '=' + v for k, v in params.items() if v]) | |||
| url = '/superset/explore/table/{table.id}/?{params}'.format(**locals()) | |||
| return redirect(url) | |||
| return(url) | |||
There was a problem hiding this comment.
return url, well actually, return '/superset/explore/table/{table.id}/?{params}'.format(**locals()) is better
|
LGTM after fixing the |
vera-liu
force-pushed
the
vliu_visualize_long_query
branch
from
faae07e to
808bd27
Compare
SalehHindi
pushed a commit
to SalehHindi/superset
that referenced
this pull request
Jun 9, 2017
… queries (apache#1933) * Use POST in sqllab_viz instead of url params to avoid error with long queries * Delete error handling * Fix returning statement
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Solution:
needs-review @ascott @mistercrunch @bkyryliuk