Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a way to see the git SHA from the website #1956

Merged
merged 2 commits into from
Jan 12, 2017

Conversation

mistercrunch
Copy link
Member

@mistercrunch mistercrunch commented Jan 12, 2017

The SHA is stored in a static file whenever setup.py is run. I added a link to the static json file to the navbar.

screen shot 2017-01-11 at 5 54 24 pm
screen shot 2017-01-11 at 5 54 17 pm
screen shot 2017-01-11 at 5 53 54 pm

@ascott
Copy link

ascott commented Jan 12, 2017

i'm wondering if this needs to be a link in the header. is it primarily for developers to see the sha or do we want our users to have access to this as well?

could we make this link visible only to admin users? or another option would be to add it as a comment in the navbar markup, then we would just need to view source to see the sha, and we wouldn't have to show anything in the ui.

@bkyryliuk
Copy link
Member

LGTM
There are some benefits as users can report sha to us when they have issues.

@mistercrunch
Copy link
Member Author

Yeah it's a little rough to have this link there but the reason I didn't put it in as a hover or tooltip is that I didn't want to open the file for reading at every web request and didn't know how to make it available in the global jinja context.... I think it serves its purpose now and we can polish it later.

@mistercrunch mistercrunch merged commit 0ce7fc1 into apache:master Jan 12, 2017
@mistercrunch mistercrunch deleted the version_info branch January 12, 2017 20:32
SalehHindi pushed a commit to SalehHindi/superset that referenced this pull request Jun 9, 2017
* Adding a way to see the git SHA from the website

* Fixing py3 bug
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.15.2 labels Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.15.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants