-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Virtual dataset duplication #20309
feat: Virtual dataset duplication #20309
Conversation
a422c3e
to
7a88a2f
Compare
Codecov Report
@@ Coverage Diff @@
## master #20309 +/- ##
==========================================
+ Coverage 66.17% 66.36% +0.19%
==========================================
Files 1757 1767 +10
Lines 66867 67153 +286
Branches 7077 7132 +55
==========================================
+ Hits 44246 44563 +317
+ Misses 20812 20765 -47
- Partials 1809 1825 +16
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. |
aba1179
to
8b1abd8
Compare
8b1abd8
to
984ffe8
Compare
/testenv up |
@yousoph Ephemeral environment spinning up at http://52.88.76.216:8080. Credentials are |
7d2b08f
to
dc5594b
Compare
2da4c4e
to
d42fa72
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, this looks great! Just a quick nit, also would you mind writing frontend tests for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Ephemeral environment shutdown and build artifacts deleted. |
This reverts commit 16032ed.
This reverts commit 16032ed.
This reverts commit 16032ed.
SUMMARY
There is currently no way for users to copy datasets in superset. Even though they can copy the SQL of a dataset, any changes we make to the field types (e.g., in cases where we turn long, complex types into JSON, or advanced types as described in #17852) cannot be easily copied.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
See #20245
TESTING INSTRUCTIONS
There should be a button in the actions column for virtual datasets which duplicates them with the provided name when clicked.
ADDITIONAL INFORMATION