-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Changes the return type of get_permissions to be JSON friendly #20472
Conversation
Codecov Report
@@ Coverage Diff @@
## master #20472 +/- ##
==========================================
+ Coverage 66.72% 66.75% +0.02%
==========================================
Files 1739 1739
Lines 65130 65143 +13
Branches 6898 6898
==========================================
+ Hits 43459 43483 +24
+ Misses 19921 19910 -11
Partials 1750 1750
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Hooray, CI passed!! I'll test it on Preset's environment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works! Code LGTM too :)
🏷️ preset:2022.25 |
…pache#20472) * fix: Changes the return type of get_permissions to be JSON friendly * Removes dangling comma * Removes unused import * Fixes typing errors (cherry picked from commit a169b60)
SUMMARY
Changes the return type of
superset/views/utils/get_permissions
to be JSON friendly. At Preset, we noticed a bunch of serialization errors because the permissions were returned asSet
instead ofList
.Big thanks to @zephyring for investigating the issue.
TESTING INSTRUCTIONS
Before merging, we'll deploy this fix to our test environments to make sure it fixes the issue.
ADDITIONAL INFORMATION