Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Re-add schema as a searchable field for the datasets v1 API #20711

Merged
merged 1 commit into from
Jul 15, 2022

Conversation

john-bodley
Copy link
Member

SUMMARY

This PR fixes a regression introduced in #20136 where at Airbnb an existing api/v1/dataset GET request broke which was filtering on the schema name, i.e.,

{
  "message": "Filter column: schema not allowed to filter"
}

The fix is to include schema in the search_columns.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

Verified that the API request succeeded.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@john-bodley john-bodley requested review from hughhhh, etr2460 and ktmud July 14, 2022 22:00
@codecov
Copy link

codecov bot commented Jul 14, 2022

Codecov Report

Merging #20711 (bc2ceb6) into master (5beb1aa) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master   #20711   +/-   ##
=======================================
  Coverage   66.83%   66.83%           
=======================================
  Files        1750     1750           
  Lines       65894    65894           
  Branches     7017     7017           
=======================================
  Hits        44041    44041           
  Misses      20067    20067           
  Partials     1786     1786           
Flag Coverage Δ
hive 53.95% <100.00%> (ø)
javascript 51.94% <ø> (ø)
mysql 82.48% <100.00%> (ø)
postgres 82.55% <100.00%> (ø)
presto 53.81% <100.00%> (ø)
python 82.98% <100.00%> (ø)
sqlite 82.33% <100.00%> (ø)
unit 51.03% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/datasets/api.py 88.52% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5beb1aa...bc2ceb6. Read the comment docs.

Copy link
Member

@etr2460 etr2460 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for the fix

@john-bodley john-bodley merged commit 5285f3d into master Jul 15, 2022
john-bodley added a commit to airbnb/superset-fork that referenced this pull request Jul 15, 2022
(cherry picked from commit 5285f3d)
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 labels Mar 13, 2024
@mistercrunch mistercrunch deleted the john-bodley--datasets-api-search-schema branch March 26, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants