fix: switch form_data between different datasource #20867
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The Standardized Form Data is an ephemeral state keeper for keeping
form_data
between different viz. it doesn't consider switching between different data sources. If the SFD keeps a state for a viz and datasource changed, the query in the changed data source did not take effect. This PR reset the Standardized Form Data when datasource chagedBEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before
switch.ds.before.mov
After
switch.ds.after.mov
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION