Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(viz): Header scrolling for Time Table in dashboard #20874

Merged
merged 2 commits into from
Jul 27, 2022
Merged

fix(viz): Header scrolling for Time Table in dashboard #20874

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f889372
TimeTable:
Antonio-RiveroMartnez Jul 26, 2022
99817dc
Time TAble:
Antonio-RiveroMartnez Jul 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion superset-frontend/src/visualizations/TimeTable/TimeTable.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,12 +98,13 @@ const defaultProps = {
url: '',
};

// @z-index-above-dashboard-charts + 1 = 11
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, this is in the LESS codebase as z-index-above-dashboard-charts but obviously we're not using LESS here. This PR seems fine, but I wonder if we should make a levels/z-index registry in our Emotion theme. @michael-s-molina @eric-briscoe we might want to have a chat about how we can clean/support/scale these layers.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or review, most of those should not be needed at all

const TimeTableStyles = styled.div`
height: ${props => props.height}px;
overflow: auto;

th {
z-index: 1; // to cover sparkline
z-index: 11 !important; // to cover sparkline
}
`;

Expand Down