Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase query limit to 1M, add separate display limit. #2111

Merged
merged 1 commit into from
Feb 6, 2017
Merged

Increase query limit to 1M, add separate display limit. #2111

merged 1 commit into from
Feb 6, 2017

Conversation

bkyryliuk
Copy link
Member

@bkyryliuk bkyryliuk merged commit edb0111 into master Feb 6, 2017
@bkyryliuk bkyryliuk deleted the bump_limit branch February 6, 2017 18:35
@jfeng15
Copy link

jfeng15 commented Feb 7, 2017

Would there be any adverse tradeoffs if we raised the limit to say 5M or 10M instead?

@bkyryliuk
Copy link
Member Author

@jefffeng - let's be careful with that, we may run out of memory on the box.
Once we can horizontally scale the service, it will be safer to bump the limit.

SalehHindi pushed a commit to SalehHindi/superset that referenced this pull request Jun 9, 2017
@bkyryliuk
Increase query limit to 1M, add separate display limit. (apache#2111)
ecbfe49
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.16.0 labels Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bkyryliuk @jfeng15 @mistercrunch