-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added latin america countries to country map #21352
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️
We hope to see you in our Slack community too!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this wonderful addition! One question; did you use the Country Map GeoJSON Generator.ipynb
file to generate the new files? If so, would it be possible to add the changes to the notebook so these can be recreated later if needed?
Codecov Report
@@ Coverage Diff @@
## master #21352 +/- ##
==========================================
+ Coverage 66.58% 66.64% +0.06%
==========================================
Files 1790 1791 +1
Lines 68420 68436 +16
Branches 7287 7268 -19
==========================================
+ Hits 45557 45611 +54
+ Misses 20986 20964 -22
+ Partials 1877 1861 -16
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@villebro Yes. I did use the generator file. I just pushed the file with the changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates! At some point maybe we should just add all countries, lol.
@betodealmeida Did you reviewed my changes. Do I need to change anything? |
@bryanjtc thanks for the reminder. This has been open long enough, so I started CI flow and can merge once it's ready if CI is green |
SUMMARY
Added argentina, bolivia, chile, colombia, costa rica, cuba, dominican republic, ecuador, el salvador, guatemala, haiti, honduras, nicaragua, panama, paraguay, puerto rico, saint barthelemy, saint martin and venezuela.
Fixes #21440
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
Clone the repo and go to its root directory. Run the following shell commands:
cd superset-frontend && npm install
npm run plugins:storybook
ADDITIONAL INFORMATION