fix(datasets): Stop showing alert when saving from query #21442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/testenv up |
|
@yousoph Ephemeral environment spinning up at http://34.220.8.160:8080. Credentials are |
Codecov Report
@@ Coverage Diff @@
## master #21442 +/- ##
=======================================
Coverage 66.53% 66.53%
=======================================
Files 1791 1791
Lines 68599 68599
Branches 7320 7320
=======================================
Hits 45645 45645
Misses 21064 21064
Partials 1890 1890
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
eschutho
requested changes
Sep 23, 2022
| @@ -272,6 +272,7 @@ export const ControlPanelsContainer = (props: ControlPanelsContainerProps) => { | |||
| useEffect(() => { | |||
| if ( | |||
| prevDatasource && | |||
| prevDatasource.type !== DatasourceType.Query && | |||
There was a problem hiding this comment.
can we use duck typing here instead of checking the datasource type itself? Just in case some other type comes along that also meets the requirements here.
eschutho
approved these changes
Oct 11, 2022
|
Ephemeral environment shutdown and build artifacts deleted. |
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
When user saves from a query we should not display the alert saying that changes were retained. (Blue message)
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION