-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Race conditions with setupExtensions #21647
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Can we get also get @eric-briscoe or @samtfm approval before merging it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have too many apps!!! But that's another problem. Thanks for this!!
We should probably rename |
Codecov Report
@@ Coverage Diff @@
## master #21647 +/- ##
==========================================
+ Coverage 66.82% 66.87% +0.04%
==========================================
Files 1798 1798
Lines 68781 68989 +208
Branches 7326 7403 +77
==========================================
+ Hits 45962 46133 +171
- Misses 20944 20964 +20
- Partials 1875 1892 +17
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
deployed to a preset workspace and tested preset extension and feature flag related feature, did not find any issue. LGTM!
(cherry picked from commit de444d4)
SUMMARY
Fixes an issue for which the setupExtensions would cause unwanted race conditions when extending components.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N.A.
TESTING INSTRUCTIONS
All tests should pass
ADDITIONAL INFORMATION