fix(sqllab): remove set state on component update lifecycle

[justinpark]

SUMMARY

Since the legacy TabbedSqlEditor component uses UNSAFE_componentWillReceiveProps lifecycle method to update the state for editorQueries and dataPreviewQueries, which only consumes in the result panel.
This can also violate the maximum update depth exceeded in some point.

This commit deprecates UNSAFE_componentWillReceiveProps implementation and moves to the SouthPane connector where it actually needs.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

After:
No errors

TESTING INSTRUCTIONS

• Turn off SQLLAB_BACKEND_PERSISTENCE
• Go to SqlLab and open a tab
• Modify the localState of redux.sqlLab.tables (remove the table data associated to the current queryEditor id) from the array) in order to trigger the following setState update during lifecycle period.

superset/superset-frontend/src/SqlLab/components/TabbedSqlEditors/index.jsx

Lines 213 to 216 in 52d33b0

	if (
	!areArraysShallowEqual(dataPreviewQueries, this.state.dataPreviewQueries)
	) {
	this.setState({ dataPreviewQueries });

• Refresh the page and check the console

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API
  cc: @ktmud

[ktmud]

LGTM

[ktmud]

Can you add more details on how to reproduce this max-depth-call-stack error?

[codecov]

Codecov Report

Merging #21771 (52d33b0) into master (d7ee443) will increase coverage by 0.04%.
The diff coverage is 50.96%.

❗ Current head 52d33b0 differs from pull request most recent head 1442a5d. Consider uploading reports for the commit 1442a5d to get more accurate results

@@            Coverage Diff             @@
##           master   #21771      +/-   ##
==========================================
+ Coverage   66.85%   66.89%   +0.04%     
==========================================
  Files        1800     1805       +5     
  Lines       68967    69064      +97     
  Branches     7339     7369      +30     
==========================================
+ Hits        46107    46203      +96     
+ Misses      20968    20953      -15     
- Partials     1892     1908      +16     

Flag	Coverage Δ
hive	52.92% <31.25%> (-0.01%)	⬇️
javascript	53.27% <49.15%> (+0.09%)	⬆️
mysql	78.35% <59.37%> (+0.09%)	⬆️
postgres	78.41% <59.37%> (+0.10%)	⬆️
presto	52.82% <31.25%> (-0.01%)	⬇️
python	81.47% <59.37%> (+0.01%)	⬆️
sqlite	76.90% <59.37%> (+0.09%)	⬆️
unit	51.06% <21.87%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...d/packages/superset-ui-chart-controls/src/index.ts	100.00% <ø> (ø)
...t-controls/src/sections/echartsTimeSeriesQuery.tsx	33.33% <0.00%> (ø)
...perset-ui-chart-controls/src/sections/sections.tsx	87.50% <0.00%> (ø)
...chart-controls/src/shared-controls/dndControls.tsx	58.33% <0.00%> (ø)
...et-ui-chart-controls/src/shared-controls/index.tsx	53.44% <0.00%> (-0.79%)	⬇️
...t-ui-chart-controls/src/shared-controls/mixins.tsx	33.33% <0.00%> (ø)
...ntend/packages/superset-ui-core/src/color/index.ts	100.00% <ø> (ø)
...ackages/superset-ui-core/src/query/types/Column.ts	100.00% <ø> (ø)
...ackages/superset-ui-core/src/utils/featureFlags.ts	100.00% <ø> (ø)
.../BigNumber/BigNumberWithTrendline/controlPanel.tsx	16.66% <0.00%> (ø)
... and 93 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[justinpark]

Can you add more details on how to reproduce this max-depth-call-stack error?

@ktmud I updated the step to reproduce

[EugeneTorap]

LGTM! Can we merge it?