-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make sure that gsheets db connection form loads properly #22361
Conversation
cfe0c2b
to
84cafac
Compare
84cafac
to
a839a84
Compare
Codecov Report
@@ Coverage Diff @@
## master #22361 +/- ##
==========================================
+ Coverage 66.85% 66.87% +0.01%
==========================================
Files 1847 1847
Lines 70561 70553 -8
Branches 7737 7736 -1
==========================================
+ Hits 47174 47179 +5
+ Misses 21380 21373 -7
+ Partials 2007 2001 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
/testenv up |
@eschutho Ephemeral environment spinning up at http://54.202.209.100:8080. Credentials are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, I also tested this locally and everything works as described.
Ephemeral environment shutdown and build artifacts deleted. |
SUMMARY
In #21573 we added a hook to load the driver for the database selected, but it was causing some runtime errors for gsheets, so I moved it to the base db connection modal component.
TESTING INSTRUCTIONS
Opening a db connection modal edit screen for gsheets should work. Also, as a side effect, creating saving and editing databases should still work properly and should be passing a driver param to the api.
ADDITIONAL INFORMATION