Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: show database UUID in API #22411

Merged
merged 1 commit into from
Dec 13, 2022

Conversation

betodealmeida
Copy link
Member

SUMMARY

Show the database UUID in the /api/v1/database/ endpoint. This is useful for a lot of integrations (Databricks, dbt) I've been working on.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

WIP

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Dec 13, 2022

Codecov Report

Merging #22411 (7df4dbb) into master (368e7e6) will decrease coverage by 1.47%.
The diff coverage is 81.57%.

❗ Current head 7df4dbb differs from pull request most recent head 64699ac. Consider uploading reports for the commit 64699ac to get more accurate results

@@            Coverage Diff             @@
##           master   #22411      +/-   ##
==========================================
- Coverage   66.86%   65.38%   -1.48%     
==========================================
  Files        1847     1847              
  Lines       70567    70594      +27     
  Branches     7744     7744              
==========================================
- Hits        47184    46158    -1026     
- Misses      21382    22435    +1053     
  Partials     2001     2001              
Flag Coverage Δ
hive ?
mysql 77.98% <85.71%> (+0.02%) ⬆️
postgres 78.05% <85.71%> (+0.02%) ⬆️
presto ?
python 78.11% <85.71%> (-3.12%) ⬇️
sqlite ?
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...Filters/FilterBar/FilterControls/FilterControl.tsx 29.03% <0.00%> (ø)
...veFilters/FilterBar/FilterControls/FilterValue.tsx 6.00% <ø> (ø)
superset/databases/api.py 93.23% <ø> (-0.31%) ⬇️
superset/tasks/scheduler.py 88.88% <ø> (+9.25%) ⬆️
.../CRUD/data/database/DatabaseModal/ExtraOptions.tsx 75.00% <66.66%> (ø)
superset/utils/webdriver.py 80.53% <84.00%> (+0.75%) ⬆️
...set-frontend/src/components/Select/AsyncSelect.tsx 87.84% <100.00%> (ø)
...c/views/CRUD/data/database/DatabaseModal/index.tsx 40.99% <100.00%> (ø)
superset/config.py 91.92% <100.00%> (+0.07%) ⬆️
superset/db_engines/hive.py 0.00% <0.00%> (-85.19%) ⬇️
... and 75 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@betodealmeida
Copy link
Member Author

Thanks! I'm updating the unit tests!

@rusackas
Copy link
Member

Thanks! I'm updating the unit tests!

Hah, was just going to ask about that.

@betodealmeida betodealmeida merged commit 481b020 into apache:master Dec 13, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants