Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update changelog #22481

Merged
merged 6 commits into from
Jan 25, 2023
Merged

chore: update changelog #22481

merged 6 commits into from
Jan 25, 2023

Conversation

AAfghahi
Copy link
Member

SUMMARY

making sure 2.0 branch has a changelog that accurately reflects what's happening.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Dec 20, 2022

Codecov Report

Merging #22481 (09fd0b8) into 2.0 (5a2f5b9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              2.0   #22481   +/-   ##
=======================================
  Coverage   66.74%   66.74%           
=======================================
  Files        1740     1740           
  Lines       65408    65408           
  Branches     6926     6926           
=======================================
  Hits        43654    43654           
  Misses      19981    19981           
  Partials     1773     1773           
Flag Coverage Δ
hive 53.70% <ø> (ø)
javascript 51.82% <ø> (ø)
mysql 79.59% <ø> (ø)
postgres 79.66% <ø> (ø)
presto 53.56% <ø> (ø)
python 82.73% <ø> (ø)
sqlite 79.39% <ø> (ø)
unit 50.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

CHANGELOG.md Outdated Show resolved Hide resolved
UPDATING.md Outdated
@@ -22,16 +22,33 @@ under the License.
This file documents any backwards-incompatible changes in Superset and
assists people when migrating to a new version.

## 2.0.1
## Next
Copy link
Member

@eschutho eschutho Jan 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we shouldn't have a next in the 2.0 branch, but we'll have this in master. I think you'll want to create two different PRs.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok already merged one with next into master. Should I just deleted next here?

UPDATING.md Outdated
### Other

## 2.0.1
- [21895](https://github.com/apache/superset/pull/21895): Markdown components had their security increased by adhering to the same sanitization process enforced by Github. This means that some HTML elements found in markdowns are not allowed anymore due to the security risks they impose. If you're deploying Superset in a trusted environment and wish to use some of the blocked elements, then you can use the HTML_SANITIZATION_SCHEMA_EXTENSIONS configuration to extend the default sanitization schema. There's also the option to disable HTML sanitization using the HTML_SANITIZATION configuration but we do not recommend this approach because of the security risks. Given the provided configurations, we don't view the improved sanitization as a breaking change but as a security patch.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can go under other

UPDATING.md Outdated
@@ -24,14 +24,31 @@ assists people when migrating to a new version.

## 2.0.1

- [21895](https://github.com/apache/superset/pull/21895): Markdown components had their security increased by adhering to the same sanitization process enforced by Github. This means that some HTML elements found in markdowns are not allowed anymore due to the security risks they impose. If you're deploying Superset in a trusted environment and wish to use some of the blocked elements, then you can use the HTML_SANITIZATION_SCHEMA_EXTENSIONS configuration to extend the default sanitization schema. There's also the option to disable HTML sanitization using the HTML_SANITIZATION configuration but we do not recommend this approach because of the security risks. Given the provided configurations, we don't view the improved sanitization as a breaking change but as a security patch.
- [22022](https://github.com/apache/superset/pull/22022): HTTP API endpoints `/superset/approve` and `/superset/request_access` have been deprecated and their HTTP methods were changed from GET to POST
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this whole 2.0.1 section should be deleted.

CHANGELOG.md Outdated Show resolved Hide resolved
@AAfghahi AAfghahi merged commit b544993 into 2.0 Jan 25, 2023
eschutho added a commit to preset-io/superset that referenced this pull request Feb 24, 2023
@mistercrunch mistercrunch deleted the 20/changelog branch March 26, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants