Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade react-redux #22596

Merged
merged 1 commit into from
Jan 11, 2023
Merged

chore: upgrade react-redux #22596

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 28 additions & 29 deletions superset-frontend/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion superset-frontend/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@
"react-lines-ellipsis": "^0.15.0",
"react-loadable": "^5.5.0",
"react-query": "^3.39.2",
"react-redux": "^7.2.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we upgrade to this particular version? According to react-redux changelog the compatibility with react 18 starts with 8.0.0 (and the latest version is 8.0.5). 8.x also seems to be compatible with older versions of react so maybe we could use that?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried updating to react-redux to 8.0.5 but there is a type issue with action returned from useDispatch().
I also tried the recommended solution from https://redux.js.org/usage/usage-with-typescript#define-typed-hooks still didn't resolve the type issue. dispatch<any>() work but it only silent the error. We can hold off the update until we figure how to resolve this type issue

"react-redux": "^7.2.8",
"react-resize-detector": "^6.7.6",
"react-reverse-portal": "^2.0.1",
"react-router-dom": "^5.1.2",
Expand Down