chore: remove deprecated apis estimate_query_cost, results, sql_json, csv #24359
Conversation
Codecov Report
@@ Coverage Diff @@
## master #24359 +/- ##
==========================================
- Coverage 69.05% 69.03% -0.02%
==========================================
Files 1903 1903
Lines 74537 74384 -153
Branches 8108 8108
==========================================
- Hits 51468 51350 -118
+ Misses 20957 20922 -35
Partials 2112 2112
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
…into chore/remove-deprecated-apis-7
| @@ -713,6 +712,7 @@ def create_custom_permissions(self) -> None: | |||
| self.add_permission_view_menu("all_datasource_access", "all_datasource_access") | |||
| self.add_permission_view_menu("all_database_access", "all_database_access") | |||
| self.add_permission_view_menu("all_query_access", "all_query_access") | |||
| self.add_permission_view_menu("can_csv", "Superset") | |||
There was a problem hiding this comment.
This is going to be a custom permissions now. I think that something like can_download_chart would make more sense, so I propose we do that as a fast follow.
Another alternative is to totally remove this permission, since a user that can download a CSV, XLS related with a chart already as access to that chart data.
There was a problem hiding this comment.
Would this new perm combine both CSV/XLSX etc downloading, and chart/dashboard image downloading? I think that could make sense.
There was a problem hiding this comment.
no strong opinions about it, I'll propose it
| @@ -29,7 +29,6 @@ export const user: UserWithPermissionsAndRoles = { | |||
| ], | |||
| sql_lab: [ | |||
| ['menu_access', 'SQL Lab'], | |||
| ['can_sql_json', 'Superset'], | |||
There was a problem hiding this comment.
hmm, don't we need to add the new API perms to these fixtures? Maybe they're not covered by the current tests, so maybe we can add them later when they're needed..
There was a problem hiding this comment.
yeah, don't think their covered, sqllab FE code needs to be revisited
| @@ -713,6 +712,7 @@ def create_custom_permissions(self) -> None: | |||
| self.add_permission_view_menu("all_datasource_access", "all_datasource_access") | |||
| self.add_permission_view_menu("all_database_access", "all_database_access") | |||
| self.add_permission_view_menu("all_query_access", "all_query_access") | |||
| self.add_permission_view_menu("can_csv", "Superset") | |||
There was a problem hiding this comment.
Would this new perm combine both CSV/XLSX etc downloading, and chart/dashboard image downloading? I think that could make sense.
mistercrunch
added
🏷️ bot
SUMMARY
Removes old deprecated APIs:
/superset/estimate_query_cost/.../superset/results/.../superset/sql_json/.../superset/csv/...Effort on removing deprecated APIs from
/superset: #24332BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION