chore: Add explicit ON DELETE CASCADE for dashboard_slices #24938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-bodley
force-pushed
the
john-bodley--dashboard-slices-ondelete-cascade
branch
2 times, most recently
from
dc79d04 to
b3fc170
Compare
9 tasks
Codecov Report
@@ Coverage Diff @@
## master #24938 +/- ##
==========================================
- Coverage 69.00% 69.00% -0.01%
==========================================
Files 1906 1906
Lines 74147 74143 -4
Branches 8209 8209
==========================================
- Hits 51166 51162 -4
Misses 20858 20858
Partials 2123 2123
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
john-bodley
force-pushed
the
john-bodley--dashboard-slices-ondelete-cascade
branch
from
b3fc170 to
b7bb0dc
Compare
john-bodley
commented
Aug 9, 2023
| @@ -207,12 +207,10 @@ def test_users_can_view_own_dashboard(self): | |||
| dash.dashboard_title = "My Dashboard" | |||
| dash.slug = my_dash_slug | |||
| dash.owners = [user] | |||
| dash.slices = [] | |||
There was a problem hiding this comment.
My default this is an empty list.
|
|
||
| hidden_dash = Dashboard() | ||
| hidden_dash.dashboard_title = "Not My Dashboard" | ||
| hidden_dash.slug = not_my_dash_slug | ||
| hidden_dash.slices = [] |
| @@ -277,7 +275,6 @@ def test_user_can_not_view_unpublished_dash(self): | |||
| dash.dashboard_title = "My Dashboard" | |||
| dash.slug = slug | |||
| dash.owners = [admin_user] | |||
| dash.slices = [] | |||
| @@ -186,8 +186,6 @@ def test_raise_for_access_dashboard_as_guest_no_rbac(self): | |||
| # Create a draft dashboard that is not embedded | |||
| dash = Dashboard() | |||
| dash.dashboard_title = "My Dashboard" | |||
| dash.owners = [] | |||
| dash.slices = [] | |||
john-bodley
force-pushed
the
john-bodley--dashboard-slices-ondelete-cascade
branch
from
b7bb0dc to
ed7f067
Compare
john-bodley
force-pushed
the
john-bodley--dashboard-slices-ondelete-cascade
branch
from
ed7f067 to
dc8dae0
Compare
michael-s-molina
approved these changes
Aug 10, 2023
michael-s-molina
added
the
v3.0
michael-s-molina
pushed a commit
that referenced
this pull request
Aug 10, 2023
9 tasks
mistercrunch
added
🍒 3.0.0
🍒 3.0.1
🍒 3.0.2
🍒 3.0.3
🍒 3.0.4
🏷️ bot
vinothkumar66
pushed a commit
to vinothkumar66/superset
that referenced
this pull request
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Somewhat akin to #24628, this PR ensures explicit ON DELETE CASCADE operations are set for the
dashboard_slicestable which means these relationships don't need to be explicitly deleted for non-SQLAlchemy ORM operations.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
CI.
ADDITIONAL INFORMATION