fix: the temporal x-axis results in a none time_range. #25429

mapledan · 2023-09-27T09:34:01Z

SUMMARY

When the GENERIC_CHART_AXES feature is enabled, the time_range parameter in the API request is null.
Consequently, the from_dttm and to_dttm parameters rely on the time_range value, resulting in incorrect values being set for these parameters.
Specifically, this directly impacts the from_dttm and to_dttm variables in the Jinja as well.

Fixes #25301

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

Has associated issue:
Required feature flags:
Changes UI
Includes DB Migration (follow approval process in SIP-59)
- Migration is atomic, supports rollback & is backwards-compatible
- Confirm DB migration upgrade and downgrade tested
- Runtime estimates and downtime expectations provided
Introduces new feature or API
Removes existing feature or API

sfirke · 2023-09-27T14:54:17Z

Thanks for contributing this fix! I know from Slack that this issue affects many people. I tagged a few possible reviewers based on who has committed to that section of the codebase.

zhaoyongjie · 2023-09-27T15:46:45Z

@mapledan Thank you so much for the contribution, we should consider the multiple time filters in adhoc filters, I'll give you some snippet in this evening.

…generic_chart_axes

mapledan · 2023-09-28T14:59:10Z

I have addressed multiple cases related to the temporal filters.
Specifically:

Prioritize using the filter associated with the base_axis column.
When there is no base_axis, utilize the first temporal filter.
If None is passed as the time_range parameter, it will be corrected to NO_TIME_RANGE when calling the get_since_until_from_time_range function.
The processed time_range is not written back into the QueryObject.

…generic_chart_axes

sfirke · 2023-10-18T14:43:15Z

@zhaoyongjie are you able to review the updates from @mapledan ? 🙏

eschutho · 2023-11-02T17:46:36Z

/testenv up FEATURE_GENERIC_CHART_AXES=true

github-actions · 2023-11-02T17:48:44Z

@eschutho Ephemeral environment spinning up at http://34.220.132.241:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

eschutho · 2023-11-02T20:44:23Z

/testenv up FEATURE_GENERIC_CHART_AXES=true FEATURE_ENABLE_TEMPLATE_PROCESSING=true

betodealmeida · 2023-11-02T20:47:44Z

superset/common/query_object_factory.py

@@ -99,6 +112,30 @@ def _process_row_limit(
        )
        return apply_max_row_limit(row_limit or default_row_limit)

+    def _process_time_range(


This look good. It would be nice to define this as a staticmethod or separate function, so it's easier to test, and also add some unit tests. It's hard to understand what's going on here and what are the differnet contexts where this is running.

Thanks for your review. I have added code comments and unit tests.

github-actions · 2023-11-02T20:48:37Z

@eschutho Ephemeral environment spinning up at http://54.71.30.64:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

github-actions · 2023-11-03T16:58:23Z

Ephemeral environment shutdown and build artifacts deleted.

Co-authored-by: Elizabeth Thompson <[email protected]> (cherry picked from commit ae619b1)

* fix(sqllab): reinstate "Force trino client async execution" (apache#25680) * fix: remove unnecessary redirect (apache#25679) (cherry picked from commit da42bf2) * fix(chore): dashboard requests to database equal the number of slices it has (apache#24709) (cherry picked from commit 75a7431) * fix: bump to FAB 4.3.9 remove CSP exception (apache#25712) (cherry picked from commit 8fb0c8d) * fix(horizontal filter label): show full tooltip with ellipsis (apache#25732) (cherry picked from commit e4173d9) * fix: Revert "fix(Charts): Set max row limit + removed the option to use an empty row limit value" (apache#25753) (cherry picked from commit e2fe967) * fix: dataset update uniqueness (apache#25756) (cherry picked from commit c7f8d11) * fix(sqllab): slow pop datasource query (apache#25741) (cherry picked from commit 2a2bc82) * fix: allow for backward compatible errors (apache#25640) * fix: DB-specific quoting in Jinja macro (apache#25779) (cherry picked from commit 5659c87) * fix: Revert "fix: Apply normalization to all dttm columns (apache#25147)" (apache#25801) * fix: Resolve issue apache#24195 (apache#25804) (cherry picked from commit 8737a8a) * fix(SQL field in edit dataset modal): display full sql query (apache#25768) (cherry picked from commit 1eba712) * fix(sqllab): infinite fetching status after results are landed (apache#25814) (cherry picked from commit 3f28eeb) * fix: Fires onChange when clearing all values of single select (apache#25853) (cherry picked from commit 8061d5c) * fix: the temporal x-axis results in a none time_range. (apache#25429) Co-authored-by: Elizabeth Thompson <[email protected]> (cherry picked from commit ae619b1) * fix(table chart): Show Cell Bars correctly apache#25625 (apache#25707) (cherry picked from commit 916f7bc) * fix: remove `update_charts_owners` (apache#25843) * fix(charts): Time grain is None when dataset uses Jinja (apache#25842) (cherry picked from commit 7536dd1) * fix: Saving Mixed Chart with dashboard filter applied breaks adhoc_filter_b (apache#25877) (cherry picked from commit 268c1dc) * fix: database version field (apache#25898) (cherry picked from commit 06ffcd2) * fix: trino cursor (apache#25897) (cherry picked from commit cdb18e0) * chore: Updates CHANGELOG.md for 3.0.2 * fix(trino): allow impersonate_user flag to be imported (apache#25872) Co-authored-by: John Bodley <[email protected]> (cherry picked from commit 458be8c) * fix(table): Double percenting ad-hoc percentage metrics (apache#25857) (cherry picked from commit 784a478) * fix(sqllab): invalid sanitization on comparison symbol (apache#25903) (cherry picked from commit 581d3c7) * fix: update flask-caching to avoid breaking redis cache, solves apache#25339 (apache#25947) Co-authored-by: Ville Brofeldt <[email protected]> * fix: always denorm column value before querying values (apache#25919) * chore(colors): Updating Airbnb brand colors (apache#23619) (cherry picked from commit 6d8424c) * fix: naming denomalized to denormalized in helpers.py (apache#25973) (cherry picked from commit 5def416) * fix(helm): Restart all related deployments when bootstrap script changed (apache#25703) * fix(rls): Update text from tables to datasets in RLS modal (apache#25997) (cherry picked from commit 210f1f8) * fix: Make Select component fire onChange listener when a selection is pasted in (apache#25993) (cherry picked from commit 5fccf67) * fix(explore): redandant force param (apache#25985) (cherry picked from commit e7a1876) * chore: Optimize fetching samples logic (apache#25995) (cherry picked from commit 326ac4a) * fix(native filters): rendering performance improvement by reduce overrendering (apache#25901) (cherry picked from commit e1d73d5) * fix: update FAB to 4.3.10, Azure user info fix (apache#26037) (cherry picked from commit 628cd34) * chore: Updates CHANGELOG.md for 3.0.2 (rc2) --------- Co-authored-by: Rob Moore <[email protected]> Co-authored-by: Igor Khrol <[email protected]> Co-authored-by: Stepan <[email protected]> Co-authored-by: Daniel Vaz Gaspar <[email protected]> Co-authored-by: Ross Mabbett <[email protected]> Co-authored-by: Geido <[email protected]> Co-authored-by: Beto Dealmeida <[email protected]> Co-authored-by: JUST.in DO IT <[email protected]> Co-authored-by: Elizabeth Thompson <[email protected]> Co-authored-by: John Bodley <[email protected]> Co-authored-by: Michael S. Molina <[email protected]> Co-authored-by: mapledan <[email protected]> Co-authored-by: Arko <[email protected]> Co-authored-by: Antonio Rivero <[email protected]> Co-authored-by: Kamil Gabryjelski <[email protected]> Co-authored-by: Michael S. Molina <[email protected]> Co-authored-by: FGrobelny <[email protected]> Co-authored-by: Giacomo Barone <[email protected]> Co-authored-by: Ville Brofeldt <[email protected]> Co-authored-by: Hugh A. Miles II <[email protected]> Co-authored-by: josedev-union <[email protected]> Co-authored-by: yousoph <[email protected]> Co-authored-by: Jack Fragassi <[email protected]>

Co-authored-by: Elizabeth Thompson <[email protected]>

fix: the temporal x-axis results in a none time_range.

8f278c3

pull-request-size bot added the size/XS label Sep 27, 2023

sfirke requested review from zhaoyongjie, john-bodley and hughhhh September 27, 2023 14:53

mapledan added 3 commits September 28, 2023 14:59

Merge branch 'master' of https://github.com/apache/superset into fix/…

563cb44

…generic_chart_axes

fix: use the first temporal filter, if time_range still None

4a58dc5

fix: multiple time filters, refactor: _process_time_range

82b69e9

pull-request-size bot added size/M and removed size/XS labels Sep 28, 2023

re-run pre-commit

8e9cc1d

michael-s-molina requested review from villebro and michael-s-molina September 28, 2023 16:53

mapledan added 2 commits September 29, 2023 23:11

Correct mypy type incompatibility

355d82c

Merge branch 'master' of https://github.com/apache/superset into fix/…

e3caa11

…generic_chart_axes

mapledan mentioned this pull request Oct 26, 2023

time_grain always return None in jinja #22774

Closed

3 tasks

Merge branch 'master' into fix/generic_chart_axes

f2ae7e3

betodealmeida approved these changes Nov 2, 2023

View reviewed changes

add unit test

ff0ffd1

yousoph merged commit ae619b1 into apache:master Nov 3, 2023

michael-s-molina added the v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch label Nov 6, 2023

michael-s-molina pushed a commit that referenced this pull request Nov 6, 2023

fix: the temporal x-axis results in a none time_range. (#25429)

d590114

Co-authored-by: Elizabeth Thompson <[email protected]> (cherry picked from commit ae619b1)

mapledan deleted the fix/generic_chart_axes branch November 14, 2023 04:01

cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024

fix: the temporal x-axis results in a none time_range. (apache#25429)

bd2eef5

Co-authored-by: Elizabeth Thompson <[email protected]>

mistercrunch added 🍒 3.0.2 🍒 3.0.3 🍒 3.0.4 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024

sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024

fix: the temporal x-axis results in a none time_range. (apache#25429)

4a6004d

Co-authored-by: Elizabeth Thompson <[email protected]>

vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024

fix: the temporal x-axis results in a none time_range. (apache#25429)

ee65f10

Co-authored-by: Elizabeth Thompson <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: the temporal x-axis results in a none time_range. #25429

fix: the temporal x-axis results in a none time_range. #25429

mapledan commented Sep 27, 2023

sfirke commented Sep 27, 2023

zhaoyongjie commented Sep 27, 2023

mapledan commented Sep 28, 2023

sfirke commented Oct 18, 2023

eschutho commented Nov 2, 2023

github-actions bot commented Nov 2, 2023

eschutho commented Nov 2, 2023

betodealmeida Nov 2, 2023

mapledan Nov 3, 2023 •

edited

Loading

github-actions bot commented Nov 2, 2023

github-actions bot commented Nov 3, 2023

fix: the temporal x-axis results in a none time_range. #25429

fix: the temporal x-axis results in a none time_range. #25429

Conversation

mapledan commented Sep 27, 2023

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

sfirke commented Sep 27, 2023

zhaoyongjie commented Sep 27, 2023

mapledan commented Sep 28, 2023

sfirke commented Oct 18, 2023

eschutho commented Nov 2, 2023

github-actions bot commented Nov 2, 2023

eschutho commented Nov 2, 2023

betodealmeida Nov 2, 2023

Choose a reason for hiding this comment

mapledan Nov 3, 2023 • edited Loading

Choose a reason for hiding this comment

github-actions bot commented Nov 2, 2023

github-actions bot commented Nov 3, 2023

mapledan Nov 3, 2023 •

edited

Loading