-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Migrate saveModalActions to TypeScript #28046
refactor: Migrate saveModalActions to TypeScript #28046
Conversation
/testenv up |
@geido Ephemeral environment spinning up at http://52.38.63.144:8080. Credentials are |
…e/typescript-migration-saveModalActions
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #28046 +/- ##
==========================================
- Coverage 60.48% 60.25% -0.24%
==========================================
Files 1931 1928 -3
Lines 76236 75960 -276
Branches 8568 8585 +17
==========================================
- Hits 46114 45767 -347
- Misses 28017 28084 +67
- Partials 2105 2109 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
/testenv up |
@geido Ephemeral environment spinning up at http://35.166.154.194:8080. Credentials are |
Ephemeral environment shutdown and build artifacts deleted. |
throw error; | ||
} | ||
}; | ||
export { QueryFormData }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@EnxDev this is creating some warning. Do we need it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed it here #28786
SUMMARY
Migrate saveModalActions to TypeScript
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N.A
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION